Skip to content

Allow use of Winsorize transform without an optimization config#4546

Closed
saitcakmak wants to merge 1 commit into
facebook:mainfrom
saitcakmak:export-D84167926
Closed

Allow use of Winsorize transform without an optimization config#4546
saitcakmak wants to merge 1 commit into
facebook:mainfrom
saitcakmak:export-D84167926

Conversation

@saitcakmak
Copy link
Copy Markdown
Contributor

Summary: Allowing winsorization transform to be used without an optimization config will prevent some annoying errors in occasional notebook usage. If no opt config is provided, the transform becomes no-op.

Reviewed By: sdaulton

Differential Revision: D84167926

Summary: Allowing winsorization transform to be used without an optimization config will prevent some annoying errors in occasional notebook usage. If no opt config is provided, the transform becomes no-op.

Reviewed By: sdaulton

Differential Revision: D84167926
@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 17, 2025
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Nov 17, 2025

@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84167926.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.58%. Comparing base (56cb006) to head (f5c9a99).

Files with missing lines Patch % Lines
ax/adapter/transforms/winsorize.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4546   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         549      549           
  Lines       56850    56851    +1     
=======================================
+ Hits        54910    54912    +2     
+ Misses       1940     1939    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meta-codesync meta-codesync Bot closed this in 674c017 Nov 17, 2025
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Nov 17, 2025

This pull request has been merged in 674c017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants